Doomsday Engine

Probably related to the AV Map23 deep water, but the deep water in a part of Map11 in Alien Vendetta no longer displays properly.

I'd also imagine this is the same hack for Map29 of Plutonia 2, which has a spiral staircase after passing through the three colored doors.

Commit a016851ad9994f makes self-referencing sector detection more sophisticated so the deep water in AV map11 works correctly. It is possible that other render hacks were affects, so testing is needed again.

Had a chance to test, the deep water in that map is resolved, however, another issue seemed to pop up. At the beginning of the level is a barrier off to the right. You need to head into the cave and hit the switch at the top to lower and barrier and to continue the level. The barrier doesn't "lower" after hitting the switch, however you can walk through the barrier and continue as normal. The barrier looks properly constructed so I'm not sure what would cause this.

I did double-check the other issues mentioned here (in case they were all stemming off the same problem) and they still remain broken (I know the spiral stairs in Plutonia 2 Map29 displayed properly in 2.2, for example).

Further self-referencing line detection improvements to account for the case of AV MAP23.

Please test again and see if further render hack issues remain.

Did a decent amount of testing and the issues initially reported all appear to be resolved. Even issues I was going to report after this round of testing seem to be taken care of now, mostly related to invisible bridges. There are a couple of issues I have found though, mostly related to the 3D bridges. Some of them are still rendered with floor textures on them, and with black or blank spaces on the bottom. The 3D bridge screenshots are also from Map23 of Alien Vendetta, in the castle.

I have also attached a screenshot from Map29 of Plutonia 2. The spiral staircase now renders correctly again, but there is another 3D bridge at the top of the staircase that is rendered incorrectly.

Finally, another issue appeared, although it doesn't seem to be caused by a render hack. This is also in Map23 of Alien Vendetta, at X/Y coordinates 800/1500. The lower textures on the floor in the middle of the water aren't rendered, leaving a black area. This renders fine in Doomsday 2.2. ☑️

Think we're almost there...

Found an oddity playing Map05 of Plutonia2. This is in the starting area In the background, you can see the Imp floating above the ground. If you climb up the steps to get out of the water, you'll climb up some invisible step, so the Imp appears to be on a heightened floor. This was confirmed later on when more monsters teleported into the area and when they killed, they were seemingly floating above the ground. Could this be caused by the nearby invisible 3D bridge? ☑️

I added a test that can detect these 3D bridge constructs with some success. Now the AV map05 sector 33 floor is no longer rendered at the wrong height.

3D bridges in general could be rendered a lot better, though. It's outside the scope of this issue, but an extra plane should be drawn at the bridge height (#1585).

The 800/1500 area in Map23 of Alien Vendetta now renders properly, didn't see anything else broken as I was running through other maps.

Checked out Map05 of Plutonia 2 and the floor near the 3D bridge is no longer at the wrong height. You no longer fall through the 3D bridge either when standing on it.

As a test, I played through Map11 of Plutonia, another map where you could fall through a 3D bridge. You can still fall through the 3D bridges here. In addition, I'm not sure if this is caused by a nearby render hack (as there are no 3D bridges nearby), but in the northern part of the map, the area with the Blue Key (-600, 2600) does not have its floor textures rendered properly or anything. There is a mini-maze to get to the Blue Key, so this makes it very difficult to get in and out, especially with the Arch-viles that teleport in. ☑️

Also, one of the ways to get it, at 50, 2400, there is a bloodfall that's rendered too high. You can walk through it to get into the Blue Key area. ☑️

Noticed a new regression in Hexen map01, where the portal is leaking out... ☑️

Did some testing with the latest build. Mostly looking into Plutonia 2, but there were a couple of things remaining from Alien Vendetta, mainly the black spots underneath the 3D bridges in Map23. Also, in Map15, where the trap is at the beginning of the level, it looks like the bars lower first, and then you can see the top of another sector lower after that. You're not able to escape until that second barrier lowers. In Vanilla Doom, all you can see are the bars lowering.

For Plutonia 2, there's a couple of other issues I have encountered:

-There's this black spot right over the beginning of Map01, don't remember seeing that, right above the Plutonia 2 sign. ☑️

-In Map10, there are a ton of these holes in the floor, scattered across the level. I have a screenshot of the beginning of the level. ☑️

-In Map11, there's a pit where Arch-viles will pop up from underneath the floor when you approach them. You're not supposed to see into the pit, but you can here. I have encountered this across several other maps in Plutonia as well.

-In Map26, there's a black area around a sector that eventually rises up when you return to this area. Found at 2800, -400.

I was able to edit the description and get all of the resolved issues added in. Only problem is that some of the issues show up in a box with a horizontal scrolling bar, not sure how to make that go away.

The only remaining issues I have are in Map26 of Plutonia 2, where the black spot on the floor there is still visible, even with all the other ones gone (a fence eventually rises up where that black perimeter is). The other issue is in Map29 of Plutonia 2, there is an invisible bridge located at -4400, -2100. There is a visible floor texture here when all you should be able to see is the sky below:

Thanks! Edited the formatting a bit to remove the boxes, and added the remaining PL2 issues.

Did some testing in Plutonia, in Map07, the cages in the central courtyard (in the map's starting area) no longer render properly. When you get the Yellow Key, an Arch-vile teleports into those cages and alternates between the two until you can kill it.

Wanted to throw in another regression I encountered, this one in Map24 of Plutonia. This map has cages with Revenants and Arch-viles floating in mid-air, and two can be found at the beginning of the map. In the 2.3 releases, there are black spots of the sectors that can be seen on the ceiling.

Encountered this one in Map12 in Plutonia, diagonally across from the exit (at 800, -3200). The area that the Chaingunners stand on is completely invisible and not displayed properly. Looking at the map, the areas where the Chaingunners are enclosed with block monster lines are part of the same sector as the overall area, but it doesn't appear any special hacks are used here.

Just tested the latest fix, the Plutonia Map07 issue is now resolved, in addition to the Chaingunner floor not being rendered in Plutonia Map12. Just see a couple of issues remaining now...

Decided to test Doomsday 2.3 with my own WAD and maps I have created. While they don't use too many render hacks, there were some rendering issues in areas where there's weren't any render hacks in use. Instead of uploading the entire WAD here, I created a test map (can't think of any Doom maps off the top of my head where these issues can happen) and have attached it here.

The two biggest issues that I found:

- ☑️ Doomsday 2.3 seems to have to trouble displaying floor textures of a child sector, if the child sector has a different flat than its surrounding sectors. In this test map, you should see the word "TEST" spelt out on the floor, but you cannot see this in Doomsday. This appears to only happen if the child sector is of the same height as its parent sectors, the blue "2" in the back is displayed properly, at a lower floor height.

EDIT: An example of this issue in a Doom map is Map05 of Doom II, in the closets in the center of the map (around 1600, -200). The arrows on the floor pointing to you which doors the switches in these closets open are not visible.

- ☑️ Also, Doomsday appears to have issues applying the offsets of textures when the ceiling is a sky. Across from your starting point are some bars, they have a Y offset of -40 so you should only really see the top half of them, however, in Doomsday, they are completely visible.

This is simply Map01 and has one room, hope this helps.