Project

General

Profile

Bug #2411

Monitor color adjustment via platform-specific APIs is unreliable (e.g., Windows 10)

Added by skyjake almost 5 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
skyjake
Category:
Regression
Target version:
2.3
Start date:
2020-02-01
% Done:

100%

Tags:
GL2, DisplayMode

Description

The gamma correction, brightness, and contrast color adjustment should be applied via a shader into the game view. This has advantages:
  • No reliance on platform-specific APIs (Windows 10's SetDeviceGammaRamp() is glitchy, for example).
  • Only affects the game view.
  • Full control over the color adjustment calculations.

Related issues

Related to Bug #2406: [Windows] Color adjustments are not being appliedClosed2020-01-26

Related to Feature #2160: Custom screenshader support and profilesProgressed2016-05-21

Related to Feature #2142: Color adjustment should only apply to game viewClosed2015-12-10

Associated revisions

Revision aeccb498 (diff)
Added by skyjake almost 5 years ago

GL|FX: Apply color adjustments via a shader

Gamma correction, brightness, and contrast color adjustments are applied using a frame post-processing shader, and they only affect the game view.

This removes any platform-specific dependencies the feature had.

IssueID #2411

Revision 60f2875e (diff)
Added by skyjake almost 5 years ago

Fixed|GL: Visual artifact when using color adjustments

IssueID #2411

Revision 67f07f69 (diff)
Added by skyjake almost 5 years ago

Fixed|GL: Visual artifact when using color adjustments

IssueID #2411

  1. Conflicts:
  2. doomsday/libs/gui/src/graphics/glinfo.cpp
  3. doomsday/sdk/libgui/include/de/graphics/glinfo.h

History

#1 Updated by skyjake almost 5 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

#2 Updated by skyjake almost 5 years ago

  • Related to Bug #2406: [Windows] Color adjustments are not being applied added

#3 Updated by skyjake almost 5 years ago

  • Related to Feature #2160: Custom screenshader support and profiles added

#4 Updated by skyjake almost 5 years ago

  • Related to Feature #2142: Color adjustment should only apply to game view added

#5 Updated by skyjake almost 5 years ago

  • Subject changed from Apply color adjustments via a shader (not using platform-specific APIs) to Color adjustments via platform-specific APIs is unreliable (e.g., Windows 10)

#6 Updated by skyjake almost 5 years ago

  • Subject changed from Color adjustments via platform-specific APIs is unreliable (e.g., Windows 10) to Monitor color adjustments via platform-specific APIs is unreliable (e.g., Windows 10)

#7 Updated by skyjake almost 5 years ago

  • Subject changed from Monitor color adjustments via platform-specific APIs is unreliable (e.g., Windows 10) to Monitor color adjustment via platform-specific APIs is unreliable (e.g., Windows 10)

#8 Updated by skyjake almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF