Project

General

Profile

Bug #1831

Closing Updater Settings dialog leads to checking for updates

Added by danij over 10 years ago. Updated about 10 years ago.

Status:
Closed
Priority:
Low
Assignee:
skyjake
Category:
Defect
Target version:
1.15
Start date:
2014-07-02
% Done:

100%

Tags:
UI, Updater, Client

Description

Whenever the close button is clicked in the Updater Settings dialog an update check is executed each time. Simply closing the dialog after changing no settings should not lead to an update check the user did not request.

Associated revisions

Revision 6ab3341d (diff)
Added by skyjake over 10 years ago

Fixed|UI|Updater: Don't recheck if settings weren't changed

In the update notification dialog, if one opens the Updater settings
and closes it without changing anything, a recheck of available
updates is unnecessary.

IssueID #1831

History

#1 Updated by skyjake over 10 years ago

  • Assignee set to skyjake
  • Target version set to 1.15

#2 Updated by skyjake over 10 years ago

  • Category changed from Regression to Defect
  • Status changed from New to Closed
  • Priority changed from Normal to Low
  • % Done changed from 0 to 100

#3 Updated by danij over 10 years ago

  • Status changed from Closed to In Progress

#4 Updated by danij over 10 years ago

This isn't fully fixed yet. See my comments on the relevant commit.

#5 Updated by skyjake about 10 years ago

  • Subject changed from Closing Updater Settings dialog leads to checking for updates to Updater JSON parsing error / closing Updater Settings dialog leads to checking for updates
  • Priority changed from Low to Normal

#6 Updated by skyjake about 10 years ago

  • Subject changed from Updater JSON parsing error / closing Updater Settings dialog leads to checking for updates to Closing Updater Settings dialog leads to checking for updates
  • Priority changed from Normal to Low

#7 Updated by skyjake about 10 years ago

danij wrote:

Once settings are changed once, they will forever be "changed" and cause an Update check each time the settings dialog is closed.

Many dialogs, including Updater Settings, are dynamically created when opened and deleted when closed, so keeping the "changed" flag until destruction of the dialog is not a problem.

if changing the updater settings via the gear button that appears following an update check; another update check will fire except this time, I'm unable to get out of the dialog until the update completes (which it never does) unless I cancel it.

I've never been able to reproduce this behavior. Does this happen with regularity?

I also get an alert about malformed JSON data when checking for an update using the Check Now... button in Updater Settings:

Fixed by #1937.

#8 Updated by skyjake about 10 years ago

  • Status changed from In Progress to Feedback

#9 Updated by skyjake about 10 years ago

  • Assignee changed from skyjake to danij

#10 Updated by danij about 10 years ago

skyjake wrote:

danij wrote:

if changing the updater settings via the gear button that appears following an update check; another update check will fire except this time, I'm unable to get out of the dialog until the update completes (which it never does) unless I cancel it.

I've never been able to reproduce this behavior. Does this happen with regularity?

Since your earlier fix I've been unable to replicate this behavior since. Seems fixed to me.

#11 Updated by danij about 10 years ago

  • Status changed from Feedback to Resolved

#12 Updated by skyjake about 10 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from danij to skyjake

Also available in: Atom PDF