Bug #2034
[HeXen DK] Snowberry versus Ring Zero launching
100%
Description
If one launches HeXen DK via Ring Zero, no map author is displayed with the map titles (correct behaviour).
But if one launches HeXen DK via Snowberry (i.e launches straight into the game basically), a map author is displayed; the default 'unknown' (incorrect behaviour)
Associated revisions
Snowberry|Fixed: Always load Deathkings WAD with the "-iwad" option
IssueID #2034
Snowberry: All WAD addons except hexdd.wad are loaded with "-file"
IssueID #2034
Snowberry: All WAD addons except hexdd.wad are loaded with "-file"
IssueID #2034
History
#1 Updated by danij over 9 years ago
- Category set to Defect
- Status changed from New to In Progress
- Assignee set to danij
- Priority changed from Normal to High
- Target version set to 1.15
#2 Updated by danij over 9 years ago
It appears this problem is quite simply that HEXDD.wad is being loaded twice when launched from Snowberry. A summary of what is happening in my case at least:
Selecting game 'hexen-dk'... Loading game resources... Loading "%HOMEPATH%\Documents\DOOM\IWADS\HEXEN.wad"... IWAD identification: 0x166c805 Loading "%HOMEPATH%\Documents\DOOM\IWADS\HEXDD.wad"... IWAD identification: 0x480bc0 Loading "(basedir)\data\jhexen\libhexen.pk3"... Loading "%HOMEPATH%\Documents\Doomsday Frontend\addons\HEXDD.wad"...
First HEXDD,wad is loaded as a required/startup component for the hexen-dk game mode (as IWAD data / non-custom). It is then tried again because Snowberry specifies to load it using -file (as PWAD data / custom) suggesting that the lumps it contains are being appended to the LumpIndex and thus overriding the previously loaded lumps. (Needs verifying.)
#3 Updated by danij over 9 years ago
My take is this is simply obsolete logic in Snowberry - both HEXEN.WAD and HEXDD,WAD should be specified with -iwad so that -file can be used as defined, allowing an IWAD to be passed and interpreted as a PWAD regardless of its identifier. (See relevant discussion here: #2047)
#4 Updated by danij over 9 years ago
- Tags set to Hexen, Snowberry
- Assignee changed from danij to Deng Team
#5 Updated by danij over 9 years ago
Build1595 - Snowberry is still using -file for HEXDD.wad for me.
Options.rsp:
-basedir "C:\Program Files (x86)\Doomsday" -file "C:\Users\DaniJ\Documents\Doomsday Frontend\addons\HEXDD.wad" -sfxchan 16 -notexcomp -game hexen-dk -iwad "C:\Users\DaniJ\Documents\DOOM\IWADS\HEXEN.wad"
#6 Updated by skyjake over 9 years ago
I'll do some Python debugging...
#7 Updated by skyjake over 9 years ago
- % Done changed from 0 to 20
#8 Updated by skyjake over 9 years ago
I tried it with Fedora, and it did work correctly: "-iwad" was used for both WADs, and hexdd.wad wasn't loaded twice at runtime.
#9 Updated by danij over 9 years ago
On Windows the Python sources are compiled to bytecode .pyc files I believe, perhaps the executable was built from old versions?
#10 Updated by skyjake over 9 years ago
Could you check if your copy of hexdd.wad
actually identifies itself as an IWAD? I just tried 1595 on Windows and it did also work there correctly for me.
bytecode .pyc
I think py2exe bytecompiles all the Python modules when it packages the executable, so this shouldn't be a problem.
#11 Updated by danij over 9 years ago
Note that regardless of whether hexdd.wad is marked as an IWAD it should be treated by Snowberry as a required/startup game data file and therefore specified with -iwad.
I'll check my copy...
#12 Updated by danij over 9 years ago
My copy of hexdd.wad is indeed a PWAD
#13 Updated by skyjake over 9 years ago
That's interesting. I wonder if yours is from a different version?
Well, this means Snowberry just has to treat the "hexdd-wad" addon as a special case and not rely on the identifier. I'll make the changes.
regardless of whether hexdd.wad is marked as an IWAD it should be treated by Snowberry as a required/startup game data file
Unfortunately, Snowberry lacks the concept of multiple startup data files, so this can't be solved without a kludge.
#14 Updated by danij over 9 years ago
skyjake wrote:
That's interesting. I wonder if yours is from a different version?
Could be. Mine has been patched to 1.1
#15 Updated by vermil over 9 years ago
My versions of DK 1.0 and 1.1 (from patching my 1.0 Iwad) are both marked as Iwads.
#16 Updated by skyjake over 9 years ago
- Status changed from In Progress to Resolved
- % Done changed from 20 to 100
#17 Updated by skyjake over 9 years ago
- Tags changed from Hexen, Snowberry to Hexen, Snowberry, Deathkings
#18 Updated by danij over 9 years ago
- Status changed from Resolved to Closed
Snowberry: Use "-iwad" when addon is an IWAD file
Needs testing with the next build to see if this is a sufficient fix.
IssueID #2034