Project

General

Profile

Bug #1750

[Deathkings] New game crash while viewing ending

Added by vermil over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
skyjake
Category:
Regression
Target version:
1.14.1
Start date:
2014-04-16
% Done:

100%

Tags:
InFine, Hexen, libcommon

Description

If one tries to start a new game of HeXen while the game ending is running, it causes a seg fault.

Associated revisions

Revision fe7beaf3 (diff)
Added by skyjake over 10 years ago

Fixed|Hexen: Crash when starting a new game from end game finale

FI_StackClear() can have the side effect of setting a new game action;
in this case GA_ENDDEBRIEFING. However, when starting a new game
session we must ignore any actions from the InFine stop hooks.

Todo: Is FI_StackClear() meant to trigger stop hooks?

Also changed the order of the game action enums in x_event.h to
match the other games, however this has no impact on the execution.

IssueID #1750

Revision ce55ad4b (diff)
Added by skyjake over 10 years ago

Fixed|Hexen: Crash when starting a new game from end game finale

FI_StackClear() can have the side effect of setting a new game action;
in this case GA_ENDDEBRIEFING. However, when starting a new game
session we must ignore any actions from the InFine stop hooks.

Todo: Is FI_StackClear() meant to trigger stop hooks?

Also changed the order of the game action enums in x_event.h to
match the other games, however this has no impact on the execution.

IssueID #1750

History

#1 Updated by skyjake over 10 years ago

  • Tags changed from Hexen, ending, crash to Hexen, InFine

Does this happen every time? Does it depend on which player class is active during the finale? At which point in the finale do you try to start the new game?

I got no crash in OS X...

#2 Updated by vermil over 10 years ago

Further testing reveals it's HeXen DK exclusively. The original HeXen doesn't appear to crash.

#3 Updated by skyjake over 10 years ago

  • Tags changed from Hexen, InFine to Hexen, InFine, libcommon
  • Subject changed from [HeXen] New game crash while viewing ending to [Deathkings] New game crash while viewing ending
  • Category set to Regression
  • Status changed from New to In Progress
  • Assignee set to skyjake
  • Target version set to 1.14.1

#4 Updated by skyjake over 10 years ago

  • Assignee changed from skyjake to Deng Team
  • % Done changed from 0 to 20

#5 Updated by skyjake over 10 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Deng Team to skyjake
  • % Done changed from 20 to 100

#6 Updated by skyjake over 10 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF