Doomsday Engine

- Priority: 1 --> 5

- labels: md2 pop --> Renderer, Visual Glitch, 3D Models

models.cpp:973:

// Half the distance from bottom left to top right.
float radius = (def->scale[VX] * (max[VX] - min[VX]) +
def->scale[VZ] * (max[VZ] - min[VZ])) / 3.5f;

The comment says "half", yet it's actually divided by 3.5. Changing it to 2 improves the situation but doesn't remove the popping completely.

Maybe there's a further issue with the contact spreading, or the radius isn't calculated correctly for this model?

Indeed this calculation should divide by two. I'm not sure where the 3.5 comes from. Perhaps it was originally intended as fudge factor...

I suspect the issue is either the radius calculation for the model. Or the relative position of the model vs the origin. Depending on the relative positions of the submodels, etc. The vertex coordinate ranges for each submodel should first be translated by any offset at DED level then united into a single bounding cuboid. Half the length of the diagonal of this cuboid should then yield the maximum spread range from the origin of the model, assuming it is centered on the origin (however if this is not the case then we would need to translate the origin of the spread as well).

Note that I've not looked at the model yet, or checked through the algorithm.