Project

General

Profile

Bug #2165

[2019] Automap visualization broken

Added by danij almost 8 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
skyjake
Category:
Regression
Target version:
-
Start date:
2016-07-13
% Done:

100%

Tags:
UI, Automap, Client

Description

Presently the whole automap visualization appears to be missing, map title aside. May have occurred much earlier than this build.

Associated revisions

Revision a9ad0865 (diff)
Added by skyjake almost 8 years ago

Fixed|All Games|Automap: Map is not visible in the automap

Two bugs contributed to the problem:
- map bounding box was not correctly passed to the automap widget
- Line's visibility tracking std::array was not initialized to zero

IssueID #2165

History

#1 Updated by skyjake almost 8 years ago

I have seen this issue in some of the games for several months. Could be related to GL state.

Will investigate after fixing another, more pressing bug related to TextureVariants (occasional fatal error when loading a game).

#2 Updated by skyjake almost 8 years ago

  • Target version set to 49

#3 Updated by skyjake almost 8 years ago

Testing now on Windows. Interestingly, the 32-bit release build (by the autobuilder) seems to render the automaps just fine. However, the 64-bit release build and VS2015 64-bit debug build do not.

#4 Updated by skyjake almost 8 years ago

  • Assignee set to skyjake

#5 Updated by vermil almost 8 years ago

I noticed this more than a month ago, when I had to use a Win10 laptop that could basically not handle Dday, for a while. At the time I put it down to said laptop using an Intel integrated graphics card.

#6 Updated by skyjake almost 8 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

#7 Updated by skyjake almost 8 years ago

A couple of important things to remember:
  • Function arguments are evaluated in a non-intuitive (reverse) order, and maybe be subject to other compiler-specific behavior. In this case, MSVC was making the four calls to query the map bounds, but apparently dereferenced the returned pointers all at once (which yielded the same value for each).
  • std::array must be initialized like any other variable to have a known initial value.

(Please see the fix commit.)

#8 Updated by skyjake over 7 years ago

  • Status changed from Resolved to Closed

#9 Updated by skyjake about 7 years ago

  • Target version deleted (49)

Also available in: Atom PDF