Project

General

Profile

Feature #1520

Realistic switch sound origin (compatibility option)

Added by vermil almost 14 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Enhancement
Target version:
-
Start date:
2010-06-23
% Done:

100%

Tags:
SFX

Description

The summary says all; the sound of a switch being pressed is playing at the wrong origin.

Labels: Sound


Related issues

Related to Bug #1029: Switch sound originClosed2012-04-19

History

#1 Updated by danij almost 14 years ago

What makes you think they are playing from the wrong origin?

#2 Updated by vermil almost 14 years ago

In Doom.exe and Dday 1.8.6, the switch sound's of original Doom line types, correctly, plays right in front of the linedef.

In 1.9 beta 6.9, the switch sounds of original Doom line types incorrectly plays in the centre of the sector the switch line is attached to.

For reference though, XG switches have always played switch sounds in the centre of the sector that the switch line is attached to.

#3 Updated by skyjake over 13 years ago

See bug #1029.

#4 Updated by skyjake over 13 years ago

(originally posted by anonymous SF.net user)

The four switch sounds in Doom II map07 (Dead Simple) are definitely coming from somewhere a long way from the switch.

#5 Updated by danij about 13 years ago

Are you sure about that vermil? I don't remember switch sounds ever playing from the location of the switch in Doomsday. See the following in 1.8.6's src/p_switch.c

void P_StartButton{line_t *line, bwhere_e w, int texture, int time) {
...
buttonlist[i].soundorg = (mobj_t *) &line->frontsector->soundorg;
...
}

#6 Updated by danij over 11 years ago

Turns out that the reason they appear to originate from the switch is due to a bug in vanilla DOOM which will play them relative to the player's current position.

We should fix the problem and then implement a compatibility option to replicate vanilla behaviour.

#7 Updated by skyjake over 11 years ago

- milestone: Eventually --> Version 1.9

#8 Updated by skyjake over 10 years ago

  • Tags set to SFX

#9 Updated by skyjake over 4 years ago

  • Related to Bug #1029: Switch sound origin added

#10 Updated by skyjake over 4 years ago

  • Category set to Enhancement
  • Status changed from New to Closed
  • Assignee set to skyjake
  • % Done changed from 0 to 100

#11 Updated by skyjake over 4 years ago

See commit 0f5abef8.

Also available in: Atom PDF