Project

General

Profile

Bug #2291

If music is not defined in Map Info, should fall back to the default music

Added by skyjake 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Defect
Target version:
Start date:
2018-11-04
% Done:

100%


Description

Older mods may not specify a music ID in Map Info. However, patchmapinfo.ded in the games' definitions makes the assumption that only non-custom Map Infos get the default music.

A better way to set the default songs would be to have a Music definition matching each map ID, so that if the Map Info does not specify a song, it can always fall back to choosing a Music definition based on the map ID.

Associated revisions

Revision e98b33bd (diff)
Added by skyjake 10 months ago

Music|Definitions: Fall back to default music

If a custom Map Info doesn’t specify any music, it should use the map’s default song.

Removed the default songs from the games’ patchmapinfo.ded, as that method of applying the default songs does not work with custom Map Infos that don’t set a music ID. Instead, there is now a Music definition matching each map ID.

IssueID #2291

History

#1 Updated by skyjake 10 months ago

  • Status changed from New to In Progress

#2 Updated by skyjake 10 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

#3 Updated by skyjake 10 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF