Project

General

Profile

Bug #2052

[OS X] Crash when loading a map (clang, release build)

Added by skyjake almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Deng Team
Category:
Defect
Target version:
-
Start date:
2015-05-14
% Done:

100%

Tags:
MapData, Server, Client, Mac

Description

Build 1591, Apple LLVM version 6.1.0 (clang-602.0.49).

When running the client or doomsday-server, in map.cpp, sortLineOwners gets stuck in an infinite recursion. splitLineOwners returns null, and the recursion continues down the first argument of the mergeLineOwners call.

GCC and MSVC release builds work normally.

Associated revisions

Revision aee9fecd (diff)
Added by skyjake almost 9 years ago

Fixed|Client|Map|Clang: Crash in optimized build (undefined behavior)

During line owner sorting, LineOwner was returning references to null,
which is undefined behavior according to the C++ standard. The result
was that Clang's optimizer produced incorrect code.

http://stackoverflow.com/questions/2727834/c-standard-dereferencing-null-pointer-to-get-a-reference

IssueID #2052

History

#1 Updated by skyjake almost 9 years ago

  • Tags changed from MapData, Server to MapData, Server, Mac

#2 Updated by skyjake almost 9 years ago

  • Tags changed from MapData, Server, Mac to MapData, Server, Mac, Client
  • Subject changed from [OS X] Server crashes when loading a map (clang) to [OS X] Crash when loading a map (clang)
  • Description updated (diff)

#3 Updated by skyjake almost 9 years ago

  • Description updated (diff)

#4 Updated by skyjake almost 9 years ago

  • Subject changed from [OS X] Crash when loading a map (clang) to [OS X] Crash when loading a map (clang, release build)

#5 Updated by skyjake almost 9 years ago

  • % Done changed from 0 to 50

After investigating closer, this looks a lot like an optimization bug in clang. (MSVC and GCC builds work fine.)

I'll just disable optimization on this part of the code when building with clang.

#6 Updated by skyjake almost 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 100

#7 Updated by skyjake almost 9 years ago

I dug a little deeper and found the root cause. (Which is nice because qmake doesn't easily support source file specific build options.)

#8 Updated by skyjake almost 9 years ago

  • Status changed from Resolved to Closed

#9 Updated by skyjake almost 9 years ago

  • Target version deleted (49)

Also available in: Atom PDF