Bug #1947
Heretic Treasure Chest minor Mapinfo ded and lump reading errors
0%
Description
Rather than split this into multiple reports, I decided to combine them.
The Heretic Treasure Chest was a 3 episode Heretic community map set made back in 2010. It includes both DD_DEFN and MAPINFO lump for appropriate ports.
http://www.doomworld.com/idgames/?file=levels/heretic/Ports/htchest.zip
1. Modern Dday seems unable to read the mif_nointermission flag for the second episode from the DD_DEFN lump (the alert log declares it can't read mif_mif_nointermission, strangely).
2. The MAPINFO lump appears to confuse Dday into creating an untitled 7th episode on the episode menu when it shouldn't; it should simply replace the original 3 episodes.
The alert log throws up a possibly related error about an unexpected { and the episode def's also feature a clearepisodes command that is currently unsupported by Dday.
3. Finally, the new episode names aren't being read from either the MAPINFO lump or DD_DEFN's lump (not reading them from the MAPINFO might be related to 2. above, but Dday should surly still be lifting the names from the DD_DEFN's lump).
A couple of other unrelated things one can see in the HTC.
An unused texture animation in the HTC's animdef's lump also made me notice that ZDoom's animdef's will look for patch lumps with the appropriate name if the loaded TEXTURE lumps don't feature a texture with the appropriate name. Dday appears to try to do this as well, but ends up displaying a garbage version of the texture in game.
The old kludge change in 1.9 to the default text scale in Heretic and HeXen, to deal with the text going off the bottom of the screen in non 4:3 screen resolutions, causes issues with mods that scaled the text based off the scale prior to the mentioned change. The HTC includes a custom title loop for DDay and due to the text scale changes in Dday 1.9 causes the credits page text to slightly overlap in modern Dday, when it didn't in older Dday.
History
#1
Updated by skyjake over 9 years ago
Updated by - Tags set to Heretic, Mod, Definitions
- Category set to 3rd party compatibility
#2
Updated by danij about 9 years ago
Updated by - Status changed from New to Rejected
This mod depends on various ZDoom specific features, which are not currently supported; extended MAPINFO syntax and features (clearepisodes, {} scoping, etc...), using Patch resources as textures (and allowing ANIMDEFs to place them into animations) and no doubt various other issues.
What is happening here is that the ZDoom specific stuff is being detected and then all further processing of the MAPINFO lump is aborted, leading to the numerous issues you reported.
Also, the warning about mif_nointermission in the log is due to a syntax error in the mod - Doomsday is correctly reporting (and ignoring) this.
This mod won't be playable again until we implement support for the various ZDoom specific features used in the MAPINFO lump. Previous versions of Doomsday did not look at this data at all and so it wasn't an issue.
#3
Updated by vermil about 9 years ago
Updated by I was not aware of a syntax error in the DD_DEFN lump? That said, Dday 1.8.6 appeared able to handle this syntax error and as a result didn't display the intermission as was intended. So this becomes a backward compatibility issue?
The text scale issue was sort of unrelated, but as this mod shows a tiny backward compat issue with the mentioned change, I figured I should include it in this report.
#4
Updated by danij about 9 years ago
The mif_nointermission flag was implemented during the old 1.9.0-beta days, so 1.8.6 would have baulked at its prescence regardless of syntax.
I expect that insufficient parser validation logic is the reason that particular issue went unnoticed During the mods development. This is something the 2.0 DED parser needs to improve on significantly.