Bug #1589: [Windows] Missing icons - Doomsday Engine - Tracker

Bug #1589

[Windows] Missing icons

Added by skyjake over 10 years ago. Updated over 7 years ago.

Status:

Closed

Priority:

Low

Assignee:

skyjake

Category:

Minor detail

Target version:

2.0 – Home UI & Packages

Start date:

2013-10-18

% Done:

100%

Tags:

Windows

Description

On Windows 7, icons for the main window and Add/Remove Programs are missing.

Associated revisions

Revision 10e9e15e (diff)
Added by skyjake over 10 years ago

Windows: Updated app icons, deploy Doomsday icon to data/graphics/

ClientWindow was trying to load "doomsday.ico" from a native file but
apparently it wasn't being deployed in the installation.

The app icons now contain sizes 16x16, 32x32, 48x48 and 256x256.

Related to IssueID #1589.

Revision 02e33474 (diff)
Added by skyjake over 10 years ago

Windows: Updated app icons, deploy Doomsday icon to data/graphics/

ClientWindow was trying to load "doomsday.ico" from a native file but
apparently it wasn't being deployed in the installation.

The app icons now contain sizes 16x16, 32x32, 48x48 and 256x256.

Related to IssueID #1589.

Revision 60846f92 (diff)
Added by skyjake almost 10 years ago

Windows|Installer: Added a small icon for uninstalling

Attempting a fix.

IssueID #1589

Revision 3132e327 (diff)
Added by skyjake almost 10 years ago

Windows|Client: Updated app icon

Using the reordered .ico that seems to work better.

IssueID #1589

Revision 2a2ea087 (diff)
Added by skyjake over 7 years ago

Fixed|Windows: Main window icon is missing

IssueID #1589

History

#1 Updated by skyjake over 10 years ago

Category set to Minor detail

#2 Updated by skyjake over 10 years ago

Status changed from New to In Progress
Assignee set to skyjake

#3 Updated by skyjake over 10 years ago

Assignee deleted (~~skyjake~~)
Target version deleted (~~1.12.1~~)
% Done changed from 0 to 20

I'm not sure this can be entirely fixed. Particularly the icon appearing in the Add/Remove Programs dialog is most likely up to Inno Setup, and an icon has already been specified for the installer .exe.

As shown in the related commit, doomsday.ico is now included as a native file under data/graphics/ so that it can be loaded by Qt as the main window icon.

#4 Updated by danij over 10 years ago

% Done changed from 20 to 40

Commit c7debe3 should address the missing icon in Add/Remove Programs/Control Panel. It appears that Inno Setup uses separate icon paths for everything and each must be set accordingly.

#5 Updated by sonicdoommario almost 10 years ago

Just wanted to update this. With the latest change the Doomsday desktop icons (at least on Win7 64-bit) show up fine and no manual configuring to get them to display correctly is needed.

Still showing up as a generic icon in Add/Remove Programs however.

#6 Updated by skyjake almost 10 years ago

% Done changed from 40 to 70

#7 Updated by skyjake almost 10 years ago

The updated icon of 99770c4a is being used by Inno Setup as the new uninstaller icon. This might mean that it gets confused by the included large size (256x256). We could try adding a separate icon with only the small sizes (16/32) for the uninstaller.