Project

General

Profile

Bug #932

mf2_floatbob not affecting particle generators

Added by zoeikon almost 12 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Defect
Target version:
Start date:
2010-09-10
% Done:

100%


Description

While making a new Quartz Flask and Crystal Vial complete with bubbles, I found that the bobbing of the item did nothing for the position of the Generator origin, EVEN when 'Submodel' was used to specify a submodel center as the origin.

Labels: Graphics

Associated revisions

Revision 9408252d (diff)
Added by skyjake over 8 years ago

Fixed|Particles: Particle spawn position affected by source float bobbing

When particles are spawned, in addition to floorclip, float-bobbing
is also taken into account.

Todo for later: It would be useful to have a generator flag that
determines that bobbing should be applied at a later stage, e.g.,
during rendering. This would allow for particles that appear
inside an object to stay inside it. In practice, it would be enough
to store the “bobbing phase” of the particle and have the renderer
figure out the offset based on that and time.

IssueID #932

History

#1 Updated by zoeikon over 11 years ago

Left: still vial | Right: bobbing vial, Generator not moving with it

Attachments:

#2 Updated by skyjake almost 9 years ago

  • Tags set to Particles, Renderer, 3DModel
  • Assignee set to skyjake
  • Target version changed from 1.8.6 to 1.13

#3 Updated by skyjake almost 9 years ago

  • Category set to Defect

#4 Updated by skyjake over 8 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Bobbing now affects particle spawn positions. However, it only affects the original position of the particle — as the particle lives on, bobbing will not affect it any longer.

See todo note in the commit about a useful future enhancement.

Also available in: Atom PDF