Bug #584
Wrong instruments in MUS music
100%
Description
At least in OS X (Quicktime), MUS music has become broken at some point (has worked in the past). Now some of the instruments are incorrect, resulting in odd-sounding music. Perhaps there is a mixup between the MIDI tracks, as especially the percussion seems incorrect? Maybe the MIDI percussion track is not used correctly.
Labels: Music
History
#1
Updated by danij over 15 years ago
Updated by MUS to MIDI conversion is now handled by the engine so other than playback differences between the various audio drivers, the resultant MIDI should be the same regardless which audio driver is used.
The conversion now takes place in m_mus2midi.c
I must admit that I noticed a couple of differences in the MIDI generated by this algorithm and that produced by the win32-specific winmm direct MUS to MIDI streaming.
#2
Updated by skyjake over 15 years ago
Updated by The good news is that the generated MIDI file seems OK: on Quicktime Player it sounds correct. The problem seems to be with SDL_Mixer... In OS X the Quicktime version of the music playing functions should be used instead.
#3
Updated by skyjake over 15 years ago
Solution: don't use SDL_Mixer for MIDI playback.
#4
Updated by danij over 15 years ago
Shouldn't music playback via Quicktime be moved into a seperate audio driver plugin?
I was thinking that it would be good if we left the SDL_Mixer interface as the engine-internal default but then under OS X the dsquicktime plugin would be specified as the default driver for MUS/MIDI music (currently this would be done in Snowberry but in future the default could be specified via the game config, e.g., jdoom.cfg).
#5
Updated by skyjake over 15 years ago
That sounds reasonable. Currently it's just hardcoded to use the QuickTime music interface always on OS X, but a plugin would make it cleaner.