Reworking F_Open interface removing the 'x' mode property
Previously the F_Open function defined an additional 'x' mode paramater to the standard set of fopen paramaters meaning "do not buffer". However this meaning makes no sense on non-lump files because buffering is always skipped. Furthermore, this allowed the caller to open a pseudo-stream on a lump without populating DFile's internal buffer, producing an object with an invalid internal state.
F_Open has been modified to no longer accept this property. This functionality remains however its use has been limited to within the filesys module. External users wishing to test for file/lump access should therefore use F_Access instead.
F_OpenLump has been modified to remove the dontBuffer argument for these same reasons.
Reworking F_Open interface removing the 'x' mode property
Previously the F_Open function defined an additional 'x' mode
paramater to the standard set of fopen paramaters meaning "do
not buffer". However this meaning makes no sense on non-lump
files because buffering is always skipped. Furthermore, this
allowed the caller to open a pseudo-stream on a lump without
populating DFile's internal buffer, producing an object with
an invalid internal state.
F_Open has been modified to no longer accept this property.
This functionality remains however its use has been limited
to within the filesys module. External users wishing to test
for file/lump access should therefore use F_Access instead.
F_OpenLump has been modified to remove the dontBuffer argument
for these same reasons.